From a77c8e3e5fbde8f7edfa66d38f82c32e3a1578f2 Mon Sep 17 00:00:00 2001 From: fabianArbeit Date: Tue, 22 Jul 2025 09:15:11 +0200 Subject: [PATCH] use constants --- LoadingBar.java | 3 ++- SimpleLoadingBar.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/LoadingBar.java b/LoadingBar.java index 498c7d7..fab1d5d 100644 --- a/LoadingBar.java +++ b/LoadingBar.java @@ -27,6 +27,7 @@ public class LoadingBar { private static final int MIN_LUNCH_DURATION = 30; private static final LocalTime LATEST_LUNCH_TIME = LocalTime.of(13, 30); private static final int MINS_PER_HOUR = 60; + private static final BigDecimal MINS_PER_HOUR_BD = BigDecimal.valueOf(MINS_PER_HOUR); private static final long DEFAULT_NUMBER_WORK_MINS_BEFORE_LUNCH = 5L * MINS_PER_HOUR; private static final int MAX_NUMBER_WORK_MINS_WITHOUT_LUNCH = 6 * MINS_PER_HOUR; private static final long MAX_NUMBER_WORK_MINS = 8L * MINS_PER_HOUR; @@ -443,7 +444,7 @@ public class LoadingBar { private static String minutesToTimeString(long minutes) { var minutesBD = BigDecimal.valueOf(minutes); - BigDecimal[] hoursAndMinutes = minutesBD.divideAndRemainder(BigDecimal.valueOf(MINS_PER_HOUR), MC_INTEGER); + BigDecimal[] hoursAndMinutes = minutesBD.divideAndRemainder(MINS_PER_HOUR_BD, MC_INTEGER); return LocalTime.of(hoursAndMinutes[0].intValue(), hoursAndMinutes[1].intValue()).format(TIME_FORMATTER); } } diff --git a/SimpleLoadingBar.java b/SimpleLoadingBar.java index 3219484..7ff799a 100644 --- a/SimpleLoadingBar.java +++ b/SimpleLoadingBar.java @@ -16,6 +16,7 @@ public class SimpleLoadingBar { private static final Pattern TIME_PATTERN = Pattern.compile("(?>[01]\\d|2[0-4]):[0-5]\\d"); private static final DecimalFormat PERCENTAGE_FORMAT = new DecimalFormat("00.00"); private static final int MINS_PER_HOUR = 60; + private static final BigDecimal MINS_PER_HOUR_BD = BigDecimal.valueOf(MINS_PER_HOUR); private static final int LINE_LENGTH = 100; private static final MathContext MC_INTEGER = new MathContext(1, RoundingMode.HALF_EVEN); @@ -142,7 +143,7 @@ public class SimpleLoadingBar { private static String minutesToTimeString(long minutes) { var minutesBD = BigDecimal.valueOf(minutes); - BigDecimal[] hoursAndMinutes = minutesBD.divideAndRemainder(BigDecimal.valueOf(MINS_PER_HOUR), MC_INTEGER); + BigDecimal[] hoursAndMinutes = minutesBD.divideAndRemainder(MINS_PER_HOUR_BD, MC_INTEGER); return LocalTime.of(hoursAndMinutes[0].intValue(), hoursAndMinutes[1].intValue()).format(TIME_FORMATTER); }